Updated C wrapper wrt. Torch v1.10 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stemann
force-pushed
the
stemann/ocaml_torch_1.10
branch
from
acb50ff to
6d3200a
Compare
|
What's the status now? |
|
It's been a idle for a while, but status is summarised by these comments: |
stemann
force-pushed
the
stemann/ocaml_torch_1.10
branch
from
6d3200a to
6afc28e
Compare
Closed
|
See #54 for status. |
stemann
force-pushed
the
stemann/ocaml_torch_1.10
branch
from
6afc28e to
f407437
Compare
Copied from https://github.com/LaurentMazare/ocaml-torch/tree/a6499811f40282a071179d4306afbbb6023dcc4a/src/gen/gen.ml Also updated dune-project accordingly.
stemann
force-pushed
the
stemann/ocaml_torch_1.10
branch
19 times, most recently
from
6f18889 to
beb24f2
Compare
stemann
force-pushed
the
stemann/ocaml_torch_1.10
branch
7 times, most recently
from
7f5dbfa to
aa10911
Compare
Factored out scripts - for re-use in CI and dev. container.
stemann
force-pushed
the
stemann/ocaml_torch_1.10
branch
from
aa10911 to
37c6056
Compare
|
Perhaps it would make sense to start merging some of the excellent changes here? |
|
Yes! :-) Please give Edit: I'll try to go over it as well and try to make a re-cap of the changes. |
|
This is the current main diff which covers the hand-written part ( |
|
The overall aim was to to update for Torch v1.10.2 - but also to make it easier to apply a diff of changes for subsequent version updates... |
|
Recap: General
Modified function definitionsint at_float_vec(double *values, int value_len, int type);int at_int_vec(int64_t *values, int value_len, int type);int at_grad_set_enabled(int);int at_int64_value_at_indexes(double *i, tensor, int *indexes, int indexes_len);tensor at_load(char *filename);int ato_adam(optimizer *, double learning_rate,
double beta1,
double beta2,
double weight_decay);int atm_load(char *, module *);Added function definitionsint at_is_sparse(int *, tensor)
int at_device(int *, tensor)int at_stride(tensor, int *)int at_autocast_clear_cache();
int at_autocast_decrement_nesting(int *);
int at_autocast_increment_nesting(int *);
int at_autocast_is_enabled(int *);
int at_autocast_set_enabled(int *, int b);int at_to_string(char **, tensor, int line_size)int at_get_num_threads(int *);
int at_set_num_threads(int n_threads);int ati_none(ivalue *);
int ati_bool(ivalue *, int);
int ati_string(ivalue *, char *);
int ati_tuple(ivalue *, ivalue *, int);
int ati_generic_list(ivalue *, ivalue *, int);
int ati_generic_dict(ivalue *, ivalue *, int);
int ati_int_list(ivalue *, int64_t *, int);
int ati_double_list(ivalue *, double *, int);
int ati_bool_list(ivalue *, char *, int);
int ati_string_list(ivalue *, char **, int);
int ati_tensor_list(ivalue *, tensor *, int);int ati_to_string(char **, ivalue);
int ati_to_bool(int *, ivalue);
int ati_length(int *, ivalue);
int ati_to_generic_list(ivalue, ivalue *, int);
int ati_to_generic_dict(ivalue, ivalue *, int);
int ati_to_int_list(ivalue, int64_t *, int);
int ati_to_double_list(ivalue, double *, int);
int ati_to_bool_list(ivalue, char *, int);
int ati_to_tensor_list(ivalue, tensor *, int); |
|
@DhairyaLGandhi Do you know if anyone is available for reviewing these changes? I'm at JuliaCon, FYI. |
ToucheSir
approved these changes
Aug 8, 2024
stemann
added a commit
to stemann/Torch.jl
that referenced
this pull request
Nov 6, 2024
Replaced Torch_jll v1.4 with TorchCAPI_jll v0.2; TorchCAPI_jll v0.2 is supported by Torch_jll v1.10.2. Updated Julia wrapper using Julia wrapper generator (using Julia 1.11). Updated usages of functions changed in FluxML#61 (Updated C wrapper).
stemann
added a commit
to stemann/Torch.jl
that referenced
this pull request
Nov 6, 2024
Replaced Torch_jll v1.4 with TorchCAPI_jll v0.2; TorchCAPI_jll v0.2 is supported by Torch_jll v1.10.2. Updated Julia wrapper using Julia wrapper generator (using Julia 1.11). Updated usages of functions changed in FluxML#61 (Updated C wrapper): at_grad_set_enabled.
stemann
added a commit
to stemann/Torch.jl
that referenced
this pull request
Nov 6, 2024
Replaced Torch_jll v1.4 with TorchCAPI_jll v0.2; TorchCAPI_jll v0.2 is supported by Torch_jll v1.10.2. Updated Julia wrapper using Julia wrapper generator (using Julia 1.11). Updated usages of functions changed in FluxML#61 (Updated C wrapper): at_grad_set_enabled.
stemann
added a commit
to stemann/Torch.jl
that referenced
this pull request
Nov 9, 2024
Replaced Torch_jll v1.4 with TorchCAPI_jll v0.2; TorchCAPI_jll v0.2 is supported by Torch_jll v1.10.2. Torch_jll uses extended platform selection (platform augmentation) which requires Julia 1.7+. Updated Julia wrapper using Julia wrapper generator (using Julia 1.11). Updated usages of functions changed in FluxML#61 (Updated C wrapper): at_grad_set_enabled.
stemann
added a commit
to stemann/Torch.jl
that referenced
this pull request
Nov 15, 2024
Replaced Torch_jll v1.4 with TorchCAPI_jll v0.2; TorchCAPI_jll v0.2 is supported by Torch_jll v1.10.2. Torch_jll uses extended platform selection (platform augmentation) which requires Julia 1.7+. Updated Julia wrapper using Julia wrapper generator (using Julia 1.11). Updated usages of functions changed in FluxML#61 (Updated C wrapper): at_grad_set_enabled.
stemann
added a commit
to stemann/Torch.jl
that referenced
this pull request
Nov 16, 2024
Replaced Torch_jll v1.4 with TorchCAPI_jll v0.2; TorchCAPI_jll v0.2 is supported by Torch_jll v1.10.2. Torch_jll uses extended platform selection (platform augmentation) which requires Julia 1.7+. Updated Julia wrapper using Julia wrapper generator (using Julia 1.11). Updated usages of functions changed in FluxML#61 (Updated C wrapper): at_grad_set_enabled.
stemann
added a commit
to stemann/Torch.jl
that referenced
this pull request
Nov 16, 2024
Replaced Torch_jll v1.4 with TorchCAPI_jll v0.2; TorchCAPI_jll v0.2 is supported by Torch_jll v1.10.2. Torch_jll uses extended platform selection (platform augmentation) which requires Julia 1.7+. Updated Julia wrapper using Julia wrapper generator (using Julia 1.11). Updated usages of functions changed in FluxML#61 (Updated C wrapper): at_grad_set_enabled.
stemann
added a commit
that referenced
this pull request
Nov 16, 2024
Updated for Torch v1.10.2, and NNlib >= v0.8 Replaced Torch_jll v1.4 with TorchCAPI_jll v0.2; TorchCAPI_jll v0.2 is supported by Torch_jll v1.10.2. Torch_jll uses extended platform selection (platform augmentation) which requires Julia 1.7+. Updated Julia wrapper using Julia wrapper generator (using Julia 1.11). Updated usages of functions changed in #61 (Updated C wrapper): E.g., at_grad_set_enabled. Also: * Changed tests to make CUDA optional * CI: Buildkite: Added testing on CUDA 11.3, and Julia 1.10, and 1.11 * CI: Added GitHub Actions workflow for running tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the C wrapper based on ocaml-torch @ 0.14 - matching Torch v1.10 (current JLL-build)
Contributes to #54 - follow-up for #56
Notable included changes:
torch_api.{cpp, h}buildkite stepsGitHub Actions workflow for building C wrapperThe last two changes could be moved to a separate PR (to reduce number of changes in this PR).To-do:
torch_api.{cpp, h}Changed torch_api.cpp to reduce diffshould be removed before merging: It is meant to reduce the diff when reviewing - it's only a bunch of indentation changes etc. to make the diff smaller.